From a6cefab9626929a39b76a3d783d8310e9f52a7f5 Mon Sep 17 00:00:00 2001 From: Carter Chen Date: Wed, 6 Nov 2024 02:58:19 -0600 Subject: [PATCH 301/301] brcmfmac: fix get_assoc_ies misused endian untranslated variable. Commit 264ae44ae2c ("brcmfmac: External roam time enhancements") correctly introduces endian conversion for "assoc_info->flags" in the function brcmf_get_assoc_ies(), but fails to use the converted value in the flags variable to check for REASSOC bit. But this does not have an impact. Because brcmfmac does not traverse this code path to query the firmware for collecting the ASSOC Request & Response IE, as the ASSOC IE is already collected from the firmware via the registered asynchronous firmware events BRCMF_E_ASSOC_REQ_IE(87) and BRCMF_E_ASSOC_RESP_IE(88). Signed-off-by: Carter Chen --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c index 05e377b812e8..973dd65a3731 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c @@ -7752,7 +7752,7 @@ static s32 brcmf_get_assoc_ies(struct brcmf_cfg80211_info *cfg, return err; } - if (assoc_info->flags & BRCMF_ASSOC_REQ_IS_REASSOC) + if (flags & BRCMF_ASSOC_REQ_IS_REASSOC) conn_info->req_ie_len = req_len - sizeof(struct dot11_reassoc_req); else conn_info->req_ie_len = req_len - sizeof(struct dot11_assoc_req); -- 2.25.1